Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import path quick suggestions - add disable option #35877

Closed
mudrz opened this issue Oct 9, 2017 · 3 comments
Closed

Import path quick suggestions - add disable option #35877

mudrz opened this issue Oct 9, 2017 · 3 comments
Assignees
Labels
javascript JavaScript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mudrz
Copy link

mudrz commented Oct 9, 2017

  • VSCode Version: 1.17.0
  • OS Version: macOS High Sierra 10.13

Could not find a setting to disable the newly enabled 'import path quick suggestions'

Reproduces without extensions: Yes

I am having a terrible experience with it

In general it would be really nice to be able to opt-out of new functionality until it is battle-tested and settled instead of disrupting existing workflows after updates.
Disabling VS Code auto-updates is not an ideal solution
(not trying to be salty, simply sounds like a nice to have feature)

@vscodebot vscodebot bot added the new release label Oct 9, 2017
@vscodebot vscodebot bot assigned mjbvz Oct 9, 2017
@vscodebot vscodebot bot added the javascript JavaScript support issues label Oct 9, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Oct 9, 2017

Yeah we can add a setting to disable this but I'm surprised you weren't seeing these issues before. Path intellisense for JS and TS has been in VSCode since 1.9, all 1.17 did was enable triggering suggestions automatically when you start writing a path.

Also can you please file separate issues for the perf and jsconfig bugs you are seeing?

@mudrz mudrz changed the title Disable import path quick suggestions Import path quick suggestions - add disable option Oct 10, 2017
@mudrz
Copy link
Author

mudrz commented Oct 10, 2017

Sure, created 2 new issues

#35970

#35971

Not sure why I wasn't seeing the issue before, it's possible that the path-intellisense extension was somehow overriding the default behaviour

@mjbvz mjbvz added this to the October 2017 milestone Oct 12, 2017
@mjbvz mjbvz closed this as completed in 73635a9 Oct 13, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Oct 13, 2017

Added a typescript.quickSuggestionsForPaths setting to disable this. It is enabled by default

Should be in next week's insiders builds

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Oct 30, 2017
@roblourens roblourens added the verified Verification succeeded label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants