Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Code fail when windows-mutex is missing in Windows #36358

Closed
joaomoreno opened this issue Oct 16, 2017 · 1 comment
Closed

Make Code fail when windows-mutex is missing in Windows #36358

joaomoreno opened this issue Oct 16, 2017 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows VS Code on Windows issues
Milestone
October 2017

Comments

@joaomoreno
Copy link
Member

So this doesn't happen again: #35765 05fc36e

cc @bpasero @roblourens
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. labels Oct 16, 2017
@joaomoreno joaomoreno added this to the October 2017 milestone Oct 16, 2017
@joaomoreno joaomoreno self-assigned this Oct 16, 2017
@joaomoreno joaomoreno added windows VS Code on Windows issues workbench and removed engineering VS Code - Build / issue tracking / etc. labels Oct 16, 2017
@bpasero
Copy link
Member

bpasero commented Oct 17, 2017

@joaomoreno would be great if your solution could also check for windows-foreground-love to be there (probably any of our optionalDependencies after all).

joaomoreno added a commit that referenced this issue Oct 18, 2017
@joaomoreno
windows: alert if windows-foreground-love is missing
6e6b252 
related to #36358
@bpasero bpasero added the verified Verification succeeded label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
2 participants
@joaomoreno @bpasero