Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming border between explorer and extensions panes #36674

Closed
fredrikaverpil opened this issue Oct 21, 2017 · 6 comments
Closed

Theming border between explorer and extensions panes #36674

fredrikaverpil opened this issue Oct 21, 2017 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@fredrikaverpil
Copy link

I'm adding a visible separator line to more clearly show the border of explorer/code/terminal, which makes it easier for me to grab these handles and resize the panes:

{
    "workbench.colorCustomizations": {
        "panel.border": "#1d262a",
        "sideBar.border": "#1d262a"
    }
}

It would also be great to be able to add such a border/separator between the explorer and extension panes.
I went to the vscode theme color reference docs but it seems this is not possible at this time.

screen shot 2017-10-18 at 11 20 47

@equinusocio
Copy link

equinusocio commented Oct 21, 2017

I think that having the top border is enough

@isidorn isidorn assigned aeschli and unassigned isidorn Oct 23, 2017
@aeschli aeschli assigned bpasero and unassigned aeschli Oct 30, 2017
@bpasero
Copy link
Member

bpasero commented Oct 31, 2017

@fredrikaverpil there is no specific border color for the split-views, but if you set contrastBorder you will see that borders show up there:

image

@bpasero bpasero added the feature-request Request for new features or functionality label Nov 6, 2017
@bpasero bpasero removed their assignment Nov 6, 2017
@bpasero bpasero added themes Color theme issues and removed workbench labels Nov 11, 2017
@eamodio
Copy link
Contributor

eamodio commented Jun 5, 2018

I would like this as well to control the top border: sideBarSectionHeader.border or sideBarSectionHeader.topBorder

See:
image

@bpasero
Copy link
Member

bpasero commented Sep 12, 2018

I added sideBarSectionHeader.border as new color.

@bpasero bpasero closed this as completed Sep 12, 2018
@bpasero bpasero self-assigned this Sep 12, 2018
@bpasero bpasero added this to the September 2018 milestone Sep 12, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 12, 2018
bpasero added a commit that referenced this issue Sep 12, 2018
@sbatten
Copy link
Member

sbatten commented Sep 25, 2018

@bpasero NIT: if the section header is selected, the focus border completely hides the section header border. It's a little weird but not too big of a deal. Feel free to close and mark as verified if this is intended.

@sbatten sbatten reopened this Sep 25, 2018
@sbatten sbatten added verification-found Issue verification failed and removed verification-needed Verification of issue is requested labels Sep 25, 2018
@bpasero
Copy link
Member

bpasero commented Sep 26, 2018

@sbatten that is not a new issue, we had that before already. If you feel strong about it, I suggest to file a separate bug for it. My change was just to give a name to a color that was already there before.

@bpasero bpasero closed this as completed Sep 26, 2018
@bpasero bpasero added verified Verification succeeded verification-needed Verification of issue is requested and removed verification-found Issue verification failed labels Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants