Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set bp on multiline expression #37694

Closed
roblourens opened this issue Nov 6, 2017 · 4 comments
Closed

Can't set bp on multiline expression #37694

roblourens opened this issue Nov 6, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Nov 6, 2017

  • Have a simple script with a multiline expression like
const abc = 'abc';
let xyz = abc.trim()
    .trim();

console.log(xyz);
  • Set a BP on the console.log line, launch
  • Paused on the BP, try to set a BP on the let xyz line

nov-05-2017 21-26-04

  • The debug adapter gets a setBreakpoints request to add the BP, then immediately another to remove it.

Works in 1.16

@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority labels Nov 6, 2017
@isidorn isidorn added this to the October 2017 milestone Nov 6, 2017
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Nov 6, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 6, 2017

I cannot reproduce this both on my Mac and on my Win VM.

@weinand can you please try reproducing this

@roblourens what debug extension are you using, node2? In order to get more information about this it would be best if you place a breakpoint here and inspect why there is an extra call to setBreakpoints

@isidorn isidorn added the info-needed Issue requires more information from poster label Nov 6, 2017
@isidorn isidorn removed this from the October 2017 milestone Nov 6, 2017
@weinand
Copy link
Contributor

weinand commented Nov 6, 2017

I can repro with node.js 7.9 and 7.10 for both protocols.
I cannot repro with node.js 8.9 and 9.0 for both protocols.

@isidorn
Copy link
Contributor

isidorn commented Nov 6, 2017

I can also repro but only for 7.9. Investigating...

@isidorn isidorn removed the info-needed Issue requires more information from poster label Nov 6, 2017
@isidorn isidorn added this to the October 2017 milestone Nov 6, 2017
@isidorn isidorn closed this as completed in 8572552 Nov 6, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 6, 2017

Verifier: please verify in great detal how breakpoints get updated in the glyph margin when:

  • a user edits the file
  • adapter changes the location of the breakpoint
  • brekapoints get added / removed while a debug session is active

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

4 participants