Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce usage of ICommonCodeEditor #37834

Closed
alexdima opened this issue Nov 8, 2017 · 0 comments
Closed

Reduce usage of ICommonCodeEditor #37834

alexdima opened this issue Nov 8, 2017 · 0 comments
Assignees
@alexdima
Labels
debt Code quality issues
Milestone
November 2017

Comments

@alexdima
Copy link
Member

alexdima commented Nov 8, 2017 •
edited

All code should depend on the real ICodeEditor.

The split into ICommonCodeEditor and ICodeEditor is purely artificial and imposes arbitrary limitations on developing the code editor.
@alexdima alexdima added the debt Code quality issues label Nov 8, 2017
@alexdima alexdima added this to the November 2017 milestone Nov 8, 2017
@alexdima alexdima self-assigned this Nov 8, 2017
alexdima added a commit that referenced this issue Nov 8, 2017
@alexdima
Move mockCodeEditor to /browser/ (#37834)
ad75f5e
alexdima added a commit that referenced this issue Nov 8, 2017
@alexdima
Renames (#37834)
dc517c0
alexdima added a commit that referenced this issue Nov 8, 2017
@alexdima
Reduce usage of ICommonCodeEditor (#37834)
8bc62f0
alexdima added a commit that referenced this issue Nov 8, 2017
@alexdima
vs/editor/contrib is /browser/ by convention (#37834)
8a79656
alexdima added a commit that referenced this issue Nov 9, 2017
@alexdima
Reduce usages of editorCommonExtensions in /common/ (#37834)
3d1ccaa
alexdima added a commit that referenced this issue Nov 9, 2017
@alexdima
Consolidate EditorExtensionsRegistry (#37834)
54ede18
alexdima added a commit that referenced this issue Nov 9, 2017
@alexdima
Bring ICodeEditorService to /browser/ (#37834)
aa14fc5
alexdima added a commit that referenced this issue Nov 10, 2017
@alexdima
Reduce usages of ICommonCodeEditor (#37834)
e499dc6
alexdima added a commit that referenced this issue Nov 10, 2017
@alexdima
Reduce usage of ICommonCodeEditor (#37834)
139a4a2
alexdima added a commit that referenced this issue Nov 10, 2017
@alexdima
Remove ICommonCodeEditor (#37834)
82b13bc
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
1 participant
@alexdima