Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endless restart loop #38215

Closed
weinand opened this issue Nov 13, 2017 · 5 comments
Closed

endless restart loop #38215

weinand opened this issue Nov 13, 2017 · 5 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
November 2017

Comments

@weinand
Copy link
Contributor

weinand commented Nov 13, 2017 •
edited by sandy081

  • VSCode Version: Insiders d6fbdcf
  • OS Version: macOS

Steps to Reproduce:

  1. Opened VS Code on a single folder
  2. Open workspace settings and add a setting that will trigger restart. For example
"update.channel": "none"
  1. A prompt to restart VS Code apperas
  2. Restart VS Code
  3. Restart Prompt comes back again

2017-11-13_12-14-35

Pressing "Restart" restarts VS Code but I end up in the same situation.
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Nov 13, 2017
@vscodebot vscodebot bot added the insiders label Nov 13, 2017
@sandy081
Copy link
Member

@weinand Any errors in the console?

@weinand
Copy link
Contributor Author

weinand commented Nov 13, 2017

2017-11-13_12-30-42

@weinand
Copy link
Contributor Author

weinand commented Nov 13, 2017

BTW, I can reproduce this.

@sandy081
Copy link
Member

Ok, Will come to you to check it out. Thanks.

sandy081 added a commit that referenced this issue Nov 13, 2017
@sandy081
Tests #38215
7120fe0
sandy081 added a commit that referenced this issue Nov 13, 2017
@sandy081
Fix #38215
73830a3
@sandy081 sandy081 added the important Issue identified as high-priority label Nov 13, 2017
@sandy081 sandy081 added this to the November 2017 milestone Nov 13, 2017
@sandy081
Copy link
Member

This was happening because workspace settings are being nullified when configurations from extensions are being registered in a single folder workspace.

Marked it as important as workspace settings are not read in single folder workspace.

@weinand weinand added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@weinand @sandy081