You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You are contributing a workbench contribution which so far was instantiated right on startup, even before any UI was rendered (during service creation). We added a new parameter to allow to specify when a workbench contribution should get instantiated:
LifecyclePhase.Starting: right on startup (earliest, this was the default before)
LifecyclePhase.Restoring: right before we start to restore views and editors
LifecyclePhase.Running: after we have restored views and editors
LifecyclePhase.RunningForABit: 3 seconds after we have restored views and editors
Please check your contribution and decide which phase it should be instantiated earliest. Generally we discourage any phase before LifecyclePhase.Running if your contribution is doing something heavy.
The text was updated successfully, but these errors were encountered:
I feel you'd be better suited to do this for me @bpasero, since I'm not aware of the implications of this, while you are aware of everything scm contributes.
@joaomoreno in theory the extension host could win over the workbench, though that is rather unlikely. Are these events buffered, e.g. would they emit even if you register only after the extension host is already running?
But the extension calls registerSCMProvider, which goes through ExtHostSCM, through MainThreadSCM which can't be instantiated without the ISCMService. That scenario is only possible if ExtHostSCM exists without MainThreadSCM... and in that case, the buffering should happen at the ThreadService messaging layer, not at every consumer of the process.
Refs: #38080
You are contributing a workbench contribution which so far was instantiated right on startup, even before any UI was rendered (during service creation). We added a new parameter to allow to specify when a workbench contribution should get instantiated:
LifecyclePhase.Starting
: right on startup (earliest, this was the default before)LifecyclePhase.Restoring
: right before we start to restore views and editorsLifecyclePhase.Running
: after we have restored views and editorsLifecyclePhase.RunningForABit
: 3 seconds after we have restored views and editorsPlease check your contribution and decide which phase it should be instantiated earliest. Generally we discourage any phase before
LifecyclePhase.Running
if your contribution is doing something heavy.The text was updated successfully, but these errors were encountered: