Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock all dependencies in NPM #38342

Closed
3 tasks done
joaomoreno opened this issue Nov 14, 2017 · 11 comments
Closed
3 tasks done

Lock all dependencies in NPM #38342

joaomoreno opened this issue Nov 14, 2017 · 11 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Nov 14, 2017

A few dependencies are currently loosely locked as commits or branches in git repositories:

In order to improve dev performance, we shouldn't use this syntax any more. There are two options:

  • Integrate the changes into the upstream project and depend on that
  • Start publishing that fork into NPM under a different name
@joaomoreno joaomoreno added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Nov 14, 2017
@joaomoreno joaomoreno added this to the November 2017 milestone Nov 14, 2017
@joaomoreno joaomoreno changed the title Lock chokidar as an NPM dependency Lock all dependencies in NPM Nov 14, 2017
@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

@joaomoreno my latest experiments with chokidar is that we might no longer need my custom fork. It looks like I can npm install latest and it will fallback to compiling fsevents if node-pre-gyp fails. That is quite awesome! So maybe we do that as part of the yarn update 👍

@joaomoreno
Copy link
Member Author

It would be great to do it in master first, I'll merge that over to yarn.

@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

@joaomoreno we bike?

@jrieken
Copy link
Member

jrieken commented Nov 15, 2017

I wanna explore not having the v8-profiler dependency anymore...

@joaomoreno
Copy link
Member Author

@jrieken Please do!

@bpasero bpasero removed their assignment Nov 15, 2017
@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

I published vscode-chokidar@1.6.1

joaomoreno added a commit that referenced this issue Nov 15, 2017
@joaomoreno
Copy link
Member Author

@Tyriar Don't forget to also update https://github.com/Microsoft/vscode/wiki/Working-with-xterm.js accordingly once you do this.

@joaomoreno
Copy link
Member Author

joaomoreno commented Nov 16, 2017

FYI For chokidar, @bpasero went with the option of creating a vscode-chokidar module, simply because chokidar depends on node-pre-gyp as a regular dependency... which would end up in our release, unnecessarily.

@jrieken jrieken removed their assignment Nov 23, 2017
@jrieken
Copy link
Member

jrieken commented Nov 23, 2017

v8-profiler is gone, say hallo to to v8-inspect-profiler (which is on npm)

@Tyriar
Copy link
Member

Tyriar commented Dec 29, 2017

We now use vscode-xterm from npm, instructions updated at https://github.com/Microsoft/vscode/wiki/Working-with-xterm.js

@joaomoreno
Copy link
Member Author

@Tyriar Excellent, thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

4 participants