-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock all dependencies in NPM #38342
Comments
@joaomoreno my latest experiments with chokidar is that we might no longer need my custom fork. It looks like I can npm install latest and it will fallback to compiling |
It would be great to do it in |
@joaomoreno we bike? |
I wanna explore not having the v8-profiler dependency anymore... |
@jrieken Please do! |
I published |
@Tyriar Don't forget to also update https://github.com/Microsoft/vscode/wiki/Working-with-xterm.js accordingly once you do this. |
FYI For |
|
We now use |
@Tyriar Excellent, thanks! |
A few dependencies are currently loosely locked as commits or branches in git repositories:
chokidar@bpasero/chokidar#vscode
- @bpaserov8-profiler@jrieken/v8-profiler#vscode
- @jriekenxterm@Tyriar/xterm.js#vscode-release/1.19
- @TyriarIn order to improve dev performance, we shouldn't use this syntax any more. There are two options:
The text was updated successfully, but these errors were encountered: