Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List suffers from 1000 paper cuts #38628

Closed
jrieken opened this issue Nov 17, 2017 · 1 comment
Closed

List suffers from 1000 paper cuts #38628

jrieken opened this issue Nov 17, 2017 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug perf verified Verification succeeded
Milestone
November 2017

Comments

@jrieken
Copy link
Member

jrieken commented Nov 17, 2017

Setting nothing in an empty list

screen shot 2017-11-17 at 16 25 15
@joaomoreno joaomoreno added this to the November 2017 milestone Nov 17, 2017
@joaomoreno joaomoreno added perf bug Issue identified by VS Code Team member as probable bug labels Nov 17, 2017
@joaomoreno
Copy link
Member

Fixed pretty much all forEach calls. Left map calls since I actually need those arrays.

Also, returning early if the splice call is a no-op. That fixes those 4.7ms when clearing the list on startup.

joaomoreno added a commit that referenced this issue Nov 20, 2017
@joaomoreno
fixes #38628
1b77525
@octref octref added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug perf verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @octref