Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Auto-Import does not work for click on suggestion #38636

Closed
tobiasviehweger opened this issue Nov 17, 2017 · 2 comments · Fixed by #38655
Closed

Typescript Auto-Import does not work for click on suggestion #38636

tobiasviehweger opened this issue Nov 17, 2017 · 2 comments · Fixed by #38655
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Milestone

Comments

@tobiasviehweger
Copy link

tobiasviehweger commented Nov 17, 2017

  • VSCode Version: 1.18.1
  • OS Version: Windows 10 FCU

Steps to Reproduce:

  1. Start typing a valid typescript type name, which can be auto-imported, but is currently not imported
    image

  2. Click on one of the types - it's not imported automatically. This works if you press Tab or Enter

Would be great to have this on click as well, especially for long type names with the same beginning, a click is faster.

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added the javascript JavaScript support issues label Nov 17, 2017
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Nov 17, 2017
@mjbvz mjbvz added this to the November 2017 milestone Nov 17, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Nov 17, 2017

Simple repo for verification:

  1. Create simple workspace with two files:

a.ts:

export const abc = 123;

b.ts:

const ab = 123;
ab|
  1. Trigger suggestions in b.ts at the |
  2. The first suggestion shown should be for ab.
  3. Click on the suggestion for abc without moving through the suggestion list

Bug
Auto import not triggered

mjbvz added a commit to mjbvz/vscode that referenced this issue Nov 17, 2017
Fixes microsoft#38636

**Bug**
When clicking on a suggestion to accept it, it may not have been resolved yet.

**Fix**
Make sure we resolve it after the click
@tobiasviehweger
Copy link
Author

This is nothing short of amazing, thanks for the quick fix @mjbvz @jrieken

@roblourens roblourens added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants