Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to snippet input location on tab #38772

Closed
brunnerh opened this issue Nov 20, 2017 · 0 comments
Closed

Scroll to snippet input location on tab #38772

brunnerh opened this issue Nov 20, 2017 · 0 comments
Assignees
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality snippets verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@brunnerh
Copy link

For very long snippets it can happen that one of the parameterized locations is outside the viewport. It would be helpful if upon tab the cursor location is scrolled into view.

Example typescript snippet where $2 is quite far down:

"Custom Element": {
	"prefix": "custom-element",
	"body": [
		"class ${1:MyComponent} extends HTMLElement",
		"{",
		"\tstatic get observedAttributes()",
		"\t{",
		"\t\treturn [];",
		"\t}",
		"",
		"\tconnectedCallback()",
		"\t{",
		"\t}",
		"",
		"\tdisconnectedCallback()",
		"\t{",
		"\t}",
		"",
		"\tattributeChangedCallback(name: string, oldValue: string, newValue: string)",
		"\t{",
		"\t}",
		"",
		"\tconstructor()",
		"\t{",
		"\t\tsuper();",
		"",
		"\t}",
		"}",
		"",
		"customElements.define(\"$2\", $1);"
	],
	"description": "Creates custom element stub."
}
@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Nov 20, 2017
@jrieken jrieken added feature-request Request for new features or functionality snippets labels Nov 22, 2017
@jrieken jrieken added this to the December 2017 milestone Dec 11, 2017
@jrieken jrieken added the verification-needed Verification of issue is requested label Dec 11, 2017
@jrieken jrieken closed this as completed Dec 11, 2017
jrieken added a commit that referenced this issue Dec 11, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
@roblourens roblourens added the verified Verification succeeded label Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality snippets verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants