Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No dependency on FileService in editor/quickfix #38920

Closed
rebornix opened this issue Nov 22, 2017 · 1 comment
Closed

No dependency on FileService in editor/quickfix #38920

rebornix opened this issue Nov 22, 2017 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Milestone
November 2017

Comments

@rebornix
Copy link
Member

Editor contrib should not depend on file service, which is not available in browser.
https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/quickFix/quickFixCommands.ts#L48-L51
@rebornix rebornix added this to the November 2017 milestone Nov 22, 2017
rebornix added a commit to rebornix/vscode that referenced this issue Nov 22, 2017
@rebornix
Fix microsoft#38920. Optional dependency to fileservice.
19adabc
@rebornix
Copy link
Member Author

#38921 Leave it to @mjbvz for merging, marking it as optional can avoid dependency on file server in standalone editor.

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Nov 22, 2017
@mjbvz mjbvz closed this as completed in 73f3e0d Nov 27, 2017
@mjbvz mjbvz added engineering VS Code - Build / issue tracking / etc. verified Verification succeeded labels Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@rebornix @mjbvz