Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hyperlink ansi escapes in the integrated terminal #39278

Closed
sindresorhus opened this issue Nov 28, 2017 · 10 comments
Closed

Support hyperlink ansi escapes in the integrated terminal #39278

sindresorhus opened this issue Nov 28, 2017 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@sindresorhus
Copy link

Cross-posting from xterm.js for discovery. Hope that's ok.

Terminal emulators are starting to support hyperlinks. While many terminals have long detected URL's and linkified them, allowing you to Command-Click or Control-Click them to open a browser, you were forced to print the long unsightly URL's on the screen. As of spring 2017 a few terminals began supporting HTML like links, where the link text and destination could be specified separately.

Example from iTerm2 3.1:
screen shot 2017-11-28 at 12 08 20

xtermjs/xterm.js#1134

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Nov 28, 2017
@cleidigh cleidigh added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 28, 2017
@Tyriar Tyriar added this to the Backlog milestone Dec 12, 2017
@Tyriar Tyriar added intergrated-terminal-xtermjs upstream-issue-linked This is an upstream issue that has been reported upstream and removed intergrated-terminal-xtermjs labels Oct 8, 2019
@ssbarnea
Copy link

Is this ever going to be fixed because lack of it makes the intergrated terminal a subpar of almost any other terminal around there.

For example, I do have file:// urls which point to locally build docs, like:

Documentation available under `file:///Users/ssbarnea/c/os/ansible-lint/.tox/docs/html/index.html`

At this moment only the file path is recognized as a link and opens the html file in editor instead of opening the URL in browser. If it would not have had the URI suffix, it was normal and desired but the URI header should make it open using the system, not the editor.

@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2020

@ssbarnea what you're point out is by design, the file is recognized and is opened in the editor just like any other file. You can create a feature request for this if you would like, as I don't think it has anything to do with this issue.

@ssbarnea
Copy link

3 years later and most terminals already implemented the hyperlink extensions, still the one from vscode does not. This is quite an issue for tools that produce human friendly terminal output (hint human friendly means to avoid displaying a long and ungly url and displaying only a title for it).

@kdelmonte
Copy link

this would be a great addition!

@just1a-person
Copy link

Even Windows Terminal supports this:

Hyperlink in Windows Terminal

@pnsak
Copy link

pnsak commented Dec 7, 2021

Any updates on this?

@ericsampson
Copy link

ericsampson commented Feb 15, 2022

Any tips on what it would take to make a PR to implement this feature @meganrogge ?

@Tyriar
Copy link
Member

Tyriar commented Feb 15, 2022

@ericsampson there's some discussion in xtermjs/xterm.js#1134 as this is primarily an upstream request

@ericsampson
Copy link

thanks @Tyriar I found that link after I posted.
I read the last two comments from you and jerch, but they talk about things that are pretty inside-baseball for a new contributor to understand what needs doing 😅

@Tyriar
Copy link
Member

Tyriar commented Aug 30, 2022

Verifier test case: printf '\e]8;id=abc;http://example.com/\e\\This is a link中国\e]8;;\e\\\n'

@Tyriar Tyriar closed this as completed in e0335f8 Aug 31, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

10 participants