Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant exclude emmet from php filetype #39369

Closed
drKnoxy opened this issue Nov 30, 2017 · 2 comments
Closed

Cant exclude emmet from php filetype #39369

drKnoxy opened this issue Nov 30, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@drKnoxy
Copy link

drKnoxy commented Nov 30, 2017

  • VSCode Version: Code 1.18.1 (929bacb, 2017-11-16T18:23:26.125Z)
  • OS Version: Darwin x64 17.2.0
  • Extensions:
Extension Author (truncated) Version
ActiveFileInStatusBar Ros 1.0.3
sort-lines Tyr 1.3.0
vscode-custom-css be5 2.5.0
vscode-icontheme-nomo-dark be5 1.3.4
vscode-svgviewer css 1.4.3
vscode-eslint dba 1.4.3
eslint-disable-snippets drK 1.1.4
prettier-vscode esb 0.26.0
php-debug fel 1.12.1
php-intellisense fel 2.0.2
code-runner for 0.8.4
macros ged 1.2.1
vscode-styled-components jpo 0.0.10
Go luk 0.6.67
php-docblocker nei 1.3.2
annotator ryu 0.10.1
ayu tea 0.10.0
gitblame wad 2.2.0
vscode-import-cost wix 2.5.1

(9 theme extensions excluded)


Steps to Reproduce:

  1. update your user setting to include "emmet.excludeLanguages": ["php"]
  2. open a .php file
  3. in a function start typing var_dump($bt
  4. err you get emmet suggestions

Reproduces without extensions: Yes

user settings, tried toggling the php.suggest.basic with no success

// Place your settings in this file to overwrite the default settings
{
  "editor.cursorBlinking": "solid",
  "editor.fontFamily": "Consolas, Source Code Pro, Lobster",
  // Consolas, Source Code Pro, Menlo, Go Mono,  Fira Code,
  "editor.fontSize": 15,
  "editor.formatOnSave": false,
  "editor.letterSpacing": 0.7,
  //   "editor.lineHeight": 22,
  "editor.minimap.enabled": false,
  "editor.renderWhitespace": "boundary",
  "editor.rulers": [100, 160],
  "editor.tabSize": 2,
  "explorer.autoReveal": false,
  "explorer.openEditors.visible": 0,
  "vscode_custom_css.imports": ["/Users/awknox/.vscodestyles.css"],
  "files.associations": {
    "*.js": "javascriptreact"
  },
  "files.trimTrailingWhitespace": true,
  "workbench.editor.enablePreview": false,
  "workbench.iconTheme": "vs-nomo-dark",
  "workbench.colorTheme": "Ayu Dark",

  // Plugins
  "prettier.singleQuote": true,
  "prettier.printWidth": 100,
  "prettier.trailingComma": "es5",
  //   "php.suggest.basic": false,
  "workbench.startupEditor": "newUntitledFile",
  "window.zoomLevel": 0,
  "workbench.panel.location": "right",
  "macros": {
    "revealSide": ["workbench.files.action.showActiveFileInExplorer", "workbench.view.explorer"]
  },
  "emmet.excludeLanguages": ["php"]
}
@vscodebot vscodebot bot added the php PHP support issues label Nov 30, 2017
@roblourens roblourens assigned ramya-rao-a and unassigned roblourens Nov 30, 2017
@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues and removed php PHP support issues labels Nov 30, 2017
@ramya-rao-a ramya-rao-a added this to the November 2017 milestone Nov 30, 2017
@ramya-rao-a
Copy link
Contributor

The setting emmet.excludeLanguages works as expected for syntaxes directly supported by emmet like html, css etc.
php is mapped to html and such mapped languages weren't getting excluded.
This has now been fixed.

Thanks for reporting @drKnoxy

@drKnoxy
Copy link
Author

drKnoxy commented Dec 1, 2017

thanks @ramya-rao-a !

@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants