Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on staged new image opens a new editor without icon #39710

Closed
mjbvz opened this issue Dec 5, 2017 · 2 comments
Closed

Clicking on staged new image opens a new editor without icon #39710

mjbvz opened this issue Dec 5, 2017 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
June 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 5, 2017 •
edited

  • VSCode Version: Code - Insiders 1.19.0-insider (8a12b29, 2017-12-04T05:14:19.063Z)
  • OS Version: Windows_NT x64 10.0.17052
  • Extensions:

Testing #39583

Steps to Reproduce:

  1. Stage new image
  2. Double click on staged image

Reproduces without extensions: Yes

Problem

The new editor tab has no icon and a weird data uri path.

a
@vscodebot vscodebot bot added the insiders label Dec 5, 2017
@mjbvz mjbvz changed the title Clicking on staged new image opens a new editor Clicking on staged new image opens a new editor without icon Dec 5, 2017
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Dec 6, 2017
@joaomoreno
Copy link
Member

@bpasero It's a git: resource, but the file extension is there.

bpasero added a commit that referenced this issue Dec 6, 2017
@bpasero
do not inline data URIs into title (part of #39710)
043329d
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editors Managing of editor widgets in workbench window and removed insiders labels Dec 6, 2017
@bpasero
Copy link
Member

bpasero commented Dec 6, 2017

Yeah this is a consequence of using a data URI that does not end with a proper file extension and so our icon label cannot find a suitable extension.

Currently no plans to fix this.

@bpasero bpasero added scm General SCM compound issues git GIT issues and removed scm General SCM compound issues labels Dec 6, 2017
@bpasero bpasero added this to the June 2018 milestone Jun 4, 2018
@bpasero bpasero closed this as completed Jun 4, 2018
bpasero added a commit that referenced this issue Jun 4, 2018
@bpasero
fix #39710
4e047b5
@chrmarti chrmarti added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @chrmarti @mjbvz