Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface save participants in UI #40030

Closed
jrieken opened this issue Dec 11, 2017 · 4 comments
Closed

Surface save participants in UI #40030

jrieken opened this issue Dec 11, 2017 · 4 comments
Assignees
@jrieken
Labels
api feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2018

Comments

@jrieken
Copy link
Member

jrieken commented Dec 11, 2017

When save participants like format or the onWillSave-event run, and take longer, users won't know. We should show an UI piece when they run.
@jrieken jrieken self-assigned this Dec 11, 2017
@jrieken jrieken added this to the December 2017 milestone Dec 11, 2017
@jrieken jrieken added the api label Dec 11, 2017
jrieken added a commit that referenced this issue Dec 11, 2017
@jrieken
know the extension id when calling on-will-save, #40030
43f2e07
jrieken added a commit that referenced this issue Dec 12, 2017
@jrieken
log failures of on-will-save-listener, #40030
eef38a2
jrieken added a commit that referenced this issue Dec 12, 2017
@jrieken
show generic progress message when running save hooks, #40030
db328de
@jrieken jrieken added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Dec 12, 2017
@jrieken jrieken closed this as completed Dec 12, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 26, 2018
@ramya-rao-a
Copy link
Contributor

@jrieken I set up a formatter that takes over a second to return results. I neither see any UI message nor anything in the output pane for Log(Extension Host)

@ramya-rao-a ramya-rao-a reopened this Feb 1, 2018
@ramya-rao-a ramya-rao-a added the verification-found Issue verification failed label Feb 1, 2018
@jrieken jrieken closed this as completed Feb 1, 2018
@jrieken
Copy link
Member Author

jrieken commented Feb 1, 2018 •
edited

Such a formatter we quickly won't don't call any. Can you try with a simple breakpoint? The code is to show progress in there so I doubt your steps are valid

@jrieken jrieken reopened this Feb 1, 2018
@jrieken jrieken added the info-needed Issue requires more information from poster label Feb 1, 2018
@jrieken jrieken modified the milestones: January 2018, February 2018 Feb 1, 2018
@ramya-rao-a
Copy link
Contributor

Such a formatter we quickly won't don't call any.

I dont' understand...

I tried testing using a slow formatter because of what's described in #40030 (comment)

@jrieken jrieken modified the milestones: February 2018, March 2018 Feb 28, 2018
@jrieken jrieken removed verification-found Issue verification failed verification-needed Verification of issue is requested labels Feb 28, 2018
@jrieken jrieken closed this as completed Mar 20, 2018
@jrieken jrieken added verification-needed Verification of issue is requested and removed info-needed Issue requires more information from poster labels Mar 20, 2018
@jrieken
Copy link
Member Author

jrieken commented Mar 26, 2018

To verify:

  • open a huge JSON file (+ 10000 lines)
  • set the formatOnSaveTimout-setting to something large, e.g 5sec
  • save the JSON file

@jrieken jrieken added the release-notes Release notes issues label Mar 28, 2018
@roblourens roblourens added the verified Verification succeeded label Mar 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
3 participants
@roblourens @jrieken @ramya-rao-a