Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectBox Custom: Alt-Up triggers native dropdown, should trigger custom #40595

Closed
cleidigh opened this issue Dec 20, 2017 · 3 comments · Fixed by #40614
Closed

SelectBox Custom: Alt-Up triggers native dropdown, should trigger custom #40595

cleidigh opened this issue Dec 20, 2017 · 3 comments · Fixed by #40614
Assignees
@cleidigh
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone
January 2018

Comments

@cleidigh
Copy link
Contributor

New SelectBox implementation

Must prevent default event that triggers native control instead of custom select box.
@cleidigh cleidigh self-assigned this Dec 20, 2017
@cleidigh cleidigh added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues labels Dec 20, 2017
@cleidigh cleidigh mentioned this issue Dec 21, 2017
Merged
cleidigh added a commit that referenced this issue Dec 21, 2017
@cleidigh
SelectBox: Trigger custom not native select with Alt-Up. Fixes: #40595 (
918eb35 
#40614)
@bpasero bpasero added this to the December 2017/January 2018 milestone Dec 21, 2017
@bpasero
Copy link
Member

bpasero commented Dec 21, 2017

@cleidigh make sure you set the milestone to the current milestone for things that are fixed so that these issues get verified at the end of the milestone 👍

@cleidigh
Copy link
Contributor Author

I will get it right sometime.. 🔢

@bpasero
Copy link
Member

bpasero commented Dec 21, 2017

:)

@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cleidigh cleidigh

Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

SelectBox: Trigger custom not native select with Alt-Up. Fixes: #40595 cleidigh/vscode
2 participants
@bpasero @cleidigh