Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support terminal bell #40832

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Support terminal bell #40832

merged 2 commits into from
Jan 2, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 26, 2017

Fixes #32184

@mjbvz any issue/alternative to the changes to CSP?

@Tyriar Tyriar added this to the December 2017/January 2018 milestone Dec 26, 2017
@Tyriar Tyriar self-assigned this Dec 26, 2017
@Tyriar Tyriar requested a review from mjbvz December 26, 2017 12:20
mjbvz
mjbvz approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSP change looks fine

@mjbvz
Copy link
Contributor

mjbvz commented Jan 2, 2018

Although you may be able to avoid needing a csp change by using the web audio api instead of an <audio> tag for the bell. Not sure about this however

@Tyriar Tyriar mentioned this pull request Jan 2, 2018
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jan 2, 2018

@mjbvz good to know, created xtermjs/xterm.js#1181

@Tyriar Tyriar merged commit 4d7d99c into master Jan 2, 2018
@Tyriar Tyriar deleted the 32184_term_bell branch January 2, 2018 20:51
@felipenmoura
Copy link

Is this in the stable version?
I'm currently using 1.19.2 and "the bell never rings" in terminal!

@Tyriar
Copy link
Member Author

Tyriar commented Feb 1, 2018

@felipenmoura the milestone indicates the version it will be release in, the January release is due out in 1-2 weeks.

@felipenmoura
Copy link

Awesome, thanks :)

@Tyriar Tyriar mentioned this pull request Feb 21, 2018
Closed
@EvilJordan
Copy link

This is still not fixed, correct? Opening an integrated terminal in OSX and typing this: echo -ne '\007' results in no bell, despite "terminal.integrated.enableBell": true

@Tyriar
Copy link
Member Author

Tyriar commented Sep 18, 2018

@EvilJordan I'm seeing errors when I try to run the bell, see xtermjs/xterm.js#1694

@EvilJordan
Copy link

@Tyriar Indeed, I see this in the Developer Tools console: ERR Unable to decode audio data

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.

Support bell character in terminal
4 participants
@Tyriar @mjbvz @felipenmoura @EvilJordan