Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt web audio API changes in xterm.js #44162

Closed
Tyriar opened this issue Feb 21, 2018 · 0 comments · Fixed by #44286
Closed

Adopt web audio API changes in xterm.js #44162

Tyriar opened this issue Feb 21, 2018 · 0 comments · Fixed by #44286
Assignees
@Tyriar
Labels
debt Code quality issues terminal Integrated terminal issues
Milestone
February 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2018

Need to pull in xtermjs/xterm.js#1200, undo CSP change in #40832 and make sure it all works.
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Feb 21, 2018
@Tyriar Tyriar added this to the February 2018 milestone Feb 21, 2018
@Tyriar Tyriar self-assigned this Feb 21, 2018
Tyriar added a commit that referenced this issue Feb 23, 2018
@Tyriar
Upgrade to use web audio api in xterm.js
9d31107 
Fixes #44162
@Tyriar Tyriar mentioned this issue Feb 23, 2018
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Milestone
February 2018
Development

Successfully merging a pull request may close this issue.

Upgrade to use web audio api in xterm.js microsoft/vscode
1 participant
@Tyriar