Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement settings search UX with split "filter" and "natural language" sections #40957

Closed
roblourens opened this issue Dec 30, 2017 · 0 comments
Closed

Implement settings search UX with split "filter" and "natural language" sections #40957

roblourens opened this issue Dec 30, 2017 · 0 comments
Assignees
@roblourens
Labels
feature-request Request for new features or functionality on-testplan settings-editor VS Code settings editor issues
Milestone
January 2018

Comments

@roblourens
Copy link
Member

Example:

image
@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Dec 30, 2017
@roblourens roblourens added this to the December 2017/January 2018 milestone Dec 30, 2017
@roblourens roblourens self-assigned this Dec 30, 2017
@roblourens roblourens mentioned this issue Dec 30, 2017
Merged
@kieferrm kieferrm mentioned this issue Jan 2, 2018
Closed
55 tasks
roblourens added a commit that referenced this issue Jan 12, 2018
@roblourens
New settings search UX - #40957 (#40958)
1aaa100 
* Basic show fuzzy results below filtered results

* Renders filtered settings without a group

* Display both local filter and remote results in their own groups on the same page

* Remove duplicates between local and remote results

* Hide empty groups more completely, port score bounds change from master, fix NPE

* Remove fuzzy settings search toggle lightbulb icon

* Render all filtered groups as dynamically sized groups

* Remove renderer knowledge of filtered/nlp

* Update setting count on each search

* Fix match ranges for default settings vs the editable settings model

* Add ISearchProvider to fix layer breakage. Fix hidden areas for filtered groups

* Fix result count and updating on editable side changes

* Simplify model rendering - render all result groups dynamically, without allocating extra space

* Fix @-searches, clean up filterSettings() code in Settings Model

* Update renderers for editable prefs model

* Fix up metadata and telemetry

* Fix clearing the results by deleting the query

* Fix duplicated commonlyUsed settings, and navigation order

* Fix nlp results order, and allow scoring results

* Remove unused memento

* Match count tweaks

* Remove obsolete padTo argument to pushGroups

* Move searchResultGroup state from renderer to preferencesModels

* Remove old fuzzy search prompt link

* Fix NPE on filterResult

* nlp/filter => remote/local

* Remove "render" term from preferencesModels

* Simplify settings editor model rendering -
All groups are wrapped in braces for consistency
When search isn't active, the search groups are removed from the editor model, not hidden by the renderer

* Remove unread 'arrays'

* Simplify hiding duplicate settings search results

* Fix blinking on slow tokenization in search reuslts
This was referenced Jan 29, 2018
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality on-testplan settings-editor VS Code settings editor issues
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
1 participant
@roblourens