Uncaught TypeError: Cannot read property 'uri' of null

[vscodeerrors]

Issue Id: 09b2db67-ec5b-f02f-7f98-25f92608977c

Versions
- 1.19.1
- 816be67
- 951f5a2
Stack
TypeError: Cannot read property 'uri' of null
/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts#L143:56 (uri)
/vs/workbench/parts/extensions/browser/extensionEditor.ts#L325:16 (repository)
/vs/workbench/browser/parts/editor/editorPart.ts#L505:16 (setInput)
/vs/workbench/browser/parts/editor/editorPart.ts#L395:28 (doSetInput)
/vs/workbench/browser/parts/editor/editorPart.ts#L348:14 (doOpenEditor)
/vs/workbench/services/editor/common/editorService.ts#L206:25 (openEditor)
/vs/workbench/services/editor/common/editorService.ts#L163:15 (doOpenEditor)
/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts#L427:28 (openEditor)
/vs/workbench/parts/extensions/browser/extensionsActions.ts#L92:34 (open)
/vs/base/common/actions.ts#L226:31 (run)

[KamilSzot]

also present on 1.19.2, prevented me from installing or even viewing cjsx extension

Caused by assuming here: e6b421a#diff-dcdf54eabe92fa9ae7150f090a9f809eR128
that: this.gallery.assets.repository is always an object and never null or undefined

And it is null because this if 232d83f#diff-5a704040f30e3eb4463336a47e6500cbR205 has no else fallback for case when version.properties is not defined. And properties is optional for version because it's of type IRawGalleryExtensionVersion bd1ada3#diff-5a704040f30e3eb4463336a47e6500cbR41

[KamilSzot]

Fix is in the same style as special case for default icon if icon asset is missing.

[joaomoreno]

@sandy081 I'm forwarding this and the respective PR to you, I'm sure you'll know immediately how to review it.