Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension that calls process.exit() brings down extension host #411

Closed
bpasero opened this issue Nov 21, 2015 · 2 comments
Closed

Extension that calls process.exit() brings down extension host #411

bpasero opened this issue Nov 21, 2015 · 2 comments
Assignees
@aeschli
Labels
important Issue identified as high-priority verified Verification succeeded
Milestone
Nov 2015 - end

Comments

@bpasero
Copy link
Member

bpasero commented Nov 21, 2015

D'oh :)

@alexandrudima fyi, I think we should prevent/override calls to process.exit() but obviously there might be more ways to bring down the host.
@bpasero bpasero self-assigned this Nov 21, 2015
@bpasero bpasero added this to the Nov 2015 - Recovery milestone Nov 21, 2015
@egamma egamma modified the milestones: Nov 2015 - end, Dec 2015 Nov 23, 2015
@bpasero bpasero modified the milestones: Nov 2015 - end, Dec 2015 Nov 23, 2015
@alexdima
Copy link
Member

On the long term, I think we should recover from extension host process crashes

bpasero added a commit that referenced this issue Nov 24, 2015
@bpasero
prevent an extension from process.exit() (fixes #411)
3d1117e
@bpasero
Copy link
Member Author

bpasero commented Nov 25, 2015

@alexandrudima could you verify this one please? it is easy to reproduce by installing the Yo extension and following the steps:

  • open vscode workspace
  • run yo from f1 and pick code-generator
  • pick the ts extension
  • pick "test" as name
  • click through until you get the conflict
  • click abort

=> in the console you should see a warning that an extension tried to call process.exit()

@bpasero bpasero assigned alexdima and unassigned bpasero Nov 25, 2015
@aeschli aeschli assigned aeschli and unassigned alexdima Nov 25, 2015
@aeschli aeschli added the verified Verification succeeded label Nov 25, 2015
@bpasero bpasero added the important Issue identified as high-priority label Nov 25, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
connor4312 added a commit that referenced this issue Sep 19, 2022
@connor4312
chore: migrate remaining commands to 'unified' interface
e2ee0e2 
This fixes #411. The unified CLI is an ongoing work item, but this gets
close to where I wanted this iteration. There is still some work that
I will track to comfortably self-host this: mainly referencing existing
Insiders/Stable install locations.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
Nov 2015 - end
Development

No branches or pull requests
5 participants
@egamma @bpasero @alexdima @aeschli and others