Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o #41271

Closed
wants to merge 44 commits into from
Closed

o #41271

wants to merge 44 commits into from

Conversation

Rmaul
Copy link

@Rmaul Rmaul commented Jan 8, 2018

No description provided.

mjbvz and others added 13 commits November 29, 2017 18:25
Fixes #38254

**bug**
In a markdown js codeblock, typing `<` auto closes to `<>`. `<` is not an auto closing pair for js but it is for markdown

**fix**
Our `shouldAutoClosePair` check defaults to return true. I think we should default to false instead
This pulls in all the pushed changes after the v3 release and more screen
reader improvements, including:

- Render row debouncer to limit re-rendering of a11y rows
- assertive live region
- Convert \t to nbsp in live region
- Bug fix in parser not exiting to normal parse mode on certain sequences
- Emit selection event on terminal (not SelectionManager)
- Use of resolution event in ScreenDprMonitor
This reverts commit b811600.
@msftclas
Copy link

msftclas commented Jan 8, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ Rmaul sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -7,7 +7,7 @@ import * as interfaces from './interfaces';
import { loadMessageBundle } from 'vscode-nls';
const localize = loadMessageBundle();

export default class MergeDectorator implements vscode.Disposable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this's been already fixed in #41131

@mjbvz mjbvz closed this Jan 9, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet