Fix auto closing of < in markdown code blocks #39347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#38254 **bug** In a markdown js codeblock, typing `<` auto closes to `<>`. `<` is not an auto closing pair for js but it is for markdown **fix** Our `shouldAutoClosePair` check defaults to return true. I think we should default to false instead
|
@alexandrudima Let's target this for next iteration. This PR only fixes one case of #38254 |
|
Ping @alexandrudima |
|
Returning |
alexdima
approved these changes
Jan 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30536
bug
In a markdown js codeblock, typing
<auto closes to<>.<is not an auto closing pair for js, but<is an auto closing pair for markdownfix
Our
shouldAutoClosePaircheck defaults to returntrueif no auto closing pairs match the current character. I think we should default tofalseinstead, although I am not too familiar with this code.