Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection with double/triple-clicks doesn't work with urls inside a terminal #41415

Closed
fabiospampinato opened this issue Jan 10, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@fabiospampinato
Copy link
Contributor

Run this in the terminal: echo "test http://google.com".

I'm used to the double-click-to-select-word thing, but it doesn't work if I'm doing it over a url. For instance I can select "test" this way, but not "google".

Also, I can't select a whole line with a triple-click if those clicks happen over a url, I can otherwise.

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jan 10, 2018
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jan 12, 2018
@Tyriar Tyriar modified the milestones: Backlog, February 2018 Jan 12, 2018
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 12, 2018
@Tyriar
Copy link
Member

Tyriar commented Jan 31, 2018

This is happening because MouseZoneManager calls preventDefault on the event when a zone is hit. See:

https://github.com/xtermjs/xterm.js/blob/62d6c242fce8cc4bc983821d914348392833ee83/src/input/MouseZoneManager.ts#L153-L158

@Tyriar
Copy link
Member

Tyriar commented Jan 31, 2018

@Tyriar Tyriar modified the milestones: February 2018, January 2018 Feb 1, 2018
@Tyriar Tyriar closed this as completed in c094367 Feb 1, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 1, 2018

Upstream issue: xtermjs/xterm.js#1021, PR: xtermjs/xterm.js#1264

@octref
Copy link
Contributor

octref commented Feb 1, 2018

@Tyriar Still doesn't seem to be fixed for me though. I'm on 5190885 with macOS 1.13.2.

@Tyriar
Copy link
Member

Tyriar commented Feb 1, 2018

@octref you're right, it's seems to be only fixed for local links (eg. echo './README.md')

@Tyriar Tyriar reopened this Feb 1, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 1, 2018

It's a little close to release, I'll fix this for URLs in the following iteration as it needs a new drop of xterm.

@Tyriar Tyriar modified the milestones: January 2018, February 2018 Feb 1, 2018
@Tyriar Tyriar closed this as completed in 3373b92 Feb 23, 2018
@Tyriar Tyriar added the verified Verification succeeded label Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants