Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull http link setup into an addon #1297

Closed
Tyriar opened this issue Feb 23, 2018 · 0 comments
Closed

Pull http link setup into an addon #1297

Tyriar opened this issue Feb 23, 2018 · 0 comments
Assignees
@Tyriar
Labels
area/links type/debt Technical debt that could slow us down in the long run
Milestone
3.2.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2018

It's getting pretty ugly handling http differently because it's built in. For example we expose setHypertextLinkHandler and setHypertextValidationCallback and need a setWillLinkActivate in order to fix microsoft/vscode#41415. It would be better if http was just another link handler but was nicely packaged in an addon.
@Tyriar Tyriar added type/debt Technical debt that could slow us down in the long run area/links labels Feb 23, 2018
@Tyriar Tyriar added this to the 3.2.0 milestone Feb 23, 2018
@Tyriar Tyriar self-assigned this Feb 23, 2018
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Feb 23, 2018
@Tyriar
Move http links to the new webLinks addon
dc82278 
Fixes xtermjs#1297
@Tyriar Tyriar mentioned this issue Feb 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/links type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
1 participant
@Tyriar