Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings editor header problems #41558

Closed
usernamehw opened this issue Jan 13, 2018 · 6 comments · Fixed by #60217
Closed

Keybindings editor header problems #41558

usernamehw opened this issue Jan 13, 2018 · 6 comments · Fixed by #60217
Assignees
Labels
good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities keybindings-editor Keybinding editor issues polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded

Comments

@usernamehw
Copy link
Contributor

  1. It changes on hover the same exact way as rows
    Expected for it to stay the same
  2. On click the 1st row is selected
    Expected for it to do nothing (or sort columns..., the point is - the current behavior is mostly confusing)
@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jan 13, 2018
@sandy081
Copy link
Member

@usernamehw Not sure if I understand the issue. Can you please elaborate it

  • Steps to reproduce or
  • Any screenshots or
  • A gif

would be helpful

@sandy081 sandy081 added info-needed Issue requires more information from poster keybindings-editor Keybinding editor issues and removed editor editor-contrib Editor collection of extras labels Jan 15, 2018
@usernamehw
Copy link
Contributor Author

Keybindings-editor header: .keybindings-list-header
keybinddings_header

Hover applies to it:
hover

Click on header selects the first row:
click

@sandy081
Copy link
Member

@usernamehw Thanks for the explanation.

It changes on hover the same exact way as rows
Expected for it to stay the same

Agreed.

On click the 1st row is selected
Expected for it to do nothing (or sort columns..., the point is - the current behavior is mostly confusing)

I see your point. It was done because when user types down arrow from search box, focus goes to first row (not header).

Happy to take a PR for this.

@vscodebot
Copy link

vscodebot bot commented Jan 24, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Jan 25, 2018
@sandy081 sandy081 reopened this Jan 25, 2018
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Sep 12, 2018
@sandy081 sandy081 added this to the September 2018 milestone Sep 12, 2018
@sandy081 sandy081 added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Sep 12, 2018
@sandy081 sandy081 modified the milestones: September 2018, Backlog Sep 12, 2018
ericallensalmon added a commit to ericallensalmon/vscode that referenced this issue Sep 24, 2018
@punteek
Copy link
Contributor

punteek commented Dec 22, 2018

So is this still an issue? If so, I can try to take a look at it!

@sandy081
Copy link
Member

sandy081 commented Jan 3, 2019

There is a PR exists already

sandy081 added a commit that referenced this issue Jan 4, 2019
Fix issues with keybindings list header behavior (#41558)
@sandy081 sandy081 removed this from the Backlog milestone Jan 4, 2019
@sandy081 sandy081 added this to the December/January 2019 milestone Jan 4, 2019
@sandy081 sandy081 added verification-needed Verification of issue is requested and removed bug Issue identified by VS Code Team member as probable bug labels Jan 4, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Jan 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities keybindings-editor Keybinding editor issues polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
4 participants