Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Stage selected ranges" etc stopped working #41940

Closed
roblourens opened this issue Jan 21, 2018 · 4 comments
Closed

"Stage selected ranges" etc stopped working #41940

roblourens opened this issue Jan 21, 2018 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone
January 2018

Comments

@roblourens
Copy link
Member

  • Open a diff editor from the scm viewlet
  • Select a change
  • Try the "stage selected ranges" or "revert selected ranges" commands
  • Nothing happens
@roblourens roblourens added the scm General SCM compound issues label Jan 21, 2018
@eamodio
Copy link
Contributor

eamodio commented Jan 22, 2018

For me the commands work (from the palette or a keyboard shortcut), but the menus don't.

@bpasero bpasero self-assigned this Jan 22, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jan 22, 2018
@bpasero bpasero added this to the January 2018 milestone Jan 22, 2018
@bpasero
Copy link
Member

bpasero commented Jan 22, 2018

I probably broke that with my menu refactoring.

@bpasero
Copy link
Member

bpasero commented Jan 23, 2018 •
edited

@isidorn fyi this was an issue with using a context for commands that is not serializable to extensions for the editor title and editor context menus. I introduced a new IEditorCommandsContext that can be send to extensions and adopted some code in EditorCommands to resolve that one to IEditorIdentifier. If we ever plan to open the "Open Editors" context menu to extensions, we should use the same guy over there as well to be safe.

@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2018

@bpasero makes sense. Thanks

@roblourens roblourens mentioned this issue Jan 31, 2018
Closed
@joaomoreno joaomoreno added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @eamodio @bpasero @isidorn