"Toggle inline view" doesn't do anything

[roblourens]

• Open diff editor
• Use ... menu
• "Toggle inline view"
• nothin doin 🐛

Related to #41940?

[bpasero]

@isidorn editorIndex is optional (the dropdown menu in the editor does not set it, only the group). I think that is causing an exception

Maybe check for all places that access editorIndex and make sure you check if the index is provided.

[isidorn]

@bpasero I checked your code and the group.getEditor should return null if I pass crap into it.
editorIndex can be 0 right? So I have to check with types.isNumber(context.editorIndex)

[bpasero]

@isidorn yeah I would throw in a call to "typeof context.editorIndex === 'number'"