Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image viewer should give an indicatin when a image is too large to present #42439

Closed
dbaeumer opened this issue Jan 30, 2018 · 3 comments
Closed

Image viewer should give an indicatin when a image is too large to present #42439

dbaeumer opened this issue Jan 30, 2018 · 3 comments
Assignees
@bpasero @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@dbaeumer
Copy link
Member

#42130

Currently I simply get
capture

Would be good to know what the max dimensions are.
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jan 30, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Jan 30, 2018

This is a file size limit, not an image dimension limit. We should makes this more clear

@bpasero bpasero added this to the January 2018 milestone Jan 31, 2018
@bpasero
Copy link
Member

bpasero commented Jan 31, 2018

Changed to:

image

@bpasero bpasero closed this as completed Jan 31, 2018
bpasero added a commit that referenced this issue Jan 31, 2018
@bpasero
fix #42439
49c5b59
@raulesgalindo
Copy link

I worked it too jeje
image

@dbaeumer dbaeumer added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@bpasero @dbaeumer @raulesgalindo @mjbvz