Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Editors: selection not updated when changing editors #42452

Closed
bpasero opened this issue Jan 30, 2018 · 6 comments
Closed

Open Editors: selection not updated when changing editors #42452

bpasero opened this issue Jan 30, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 30, 2018

Testing #41084

Steps:

  • open a couple of files
  • click on the first file in "open editors" view
  • click on another file using the editor tabs

=> the open editors view looks like this now:

image

@isidorn could be that I broke this too

@bpasero bpasero added the file-explorer Explorer widget issues label Jan 30, 2018
@isidorn isidorn added this to the January 2018 milestone Jan 30, 2018
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jan 31, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

Now when the active editor changes both the focus and the selection change in the list.
I proabaably broke this before because I was listeing on selection changes and did not want to react on this automatic setting of selection. However now you changed the open editors to react onOpen which does not get triggered when selection is programaticaly updated. So all works fine

@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@bpasero
Copy link
Member Author

bpasero commented Feb 1, 2018

@isidorn should we do the same in the files explorer to be consistent?

@isidorn
Copy link
Contributor

isidorn commented Feb 1, 2018

@bpasero we already do this in the files explorer, so we are conistent

@bpasero
Copy link
Member Author

bpasero commented Feb 1, 2018

@isidorn not for me:

flicker_chrome58

@isidorn
Copy link
Contributor

isidorn commented Feb 1, 2018

@bpasero you are correct, I have pushed 5921728 to address this

isidorn added a commit that referenced this issue Feb 1, 2018
@bpasero
Copy link
Member Author

bpasero commented Feb 1, 2018

@isidorn thanks

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants