Support suppressing commit character from being inserted during completion

[DanTup]

I have a completion provider that inserts parens when completing method calls, eg. myFunc(). Today I tried adding ( as a commit character so that if I've typed myFun and press ( then it'll still complete. However this results in myFunc()() because the completion text includes the parens, the commit character then gets added, and then the automatic closing paren.

Although I could remove the parens from the completion, then they wouldn't be inserted if you hit <enter> either.

@mjbvz suggested raising this as he may have had a similar issue with snippets in JS/TS.

Is there a good workaround for this, or can the API be extended in some way to handle this?

[jrieken]

needs thinking

[DanTup]

I'm a bit confused by the existing behaviour here... I have this code:

a.noSuchMe

In my completion the user sees noSuchMethod(...). Snippet looks like noSuchMethod(${1:invocation})${2:}

If they complete with ( then I end up with:

a.noSuchMethod((invocation))

I'm not sure how the inserted parents (from the commit character) ended up in the place they did. Are they being wrapped around the first placeholder?

[jrieken]

Closing this as designed because that's what commit characters are supposed to do, accept the completion and type that character. See https://github.com/Microsoft/vscode/blob/86230c239c24b17ba2c48533cb5d8075b1b4fed6/src/vs/vscode.d.ts#L3231-L3236.