Settings search with "bad" internet is blocked

[alexdima]

Simulate "bad" internet:

Search for settings in the Settings Editor. It will search for parts of your query, then block for 20s, then search for the rest of the query.

fyi @egamma

[sandy081]

@roblourens I provided a fix here to separate local search and remote search. So when remote search is blocked or taking too much of time, local search can still run and show results.

But, please take a look at the following few issues I noticed with remote search

1. Remote search is not cancelled when I cleared the search input
2. Showing outdated results. See in the following video, remote search is showing outdated results when filter string is cleared.
3. Can we have a timeout for remote search? For eg., cancel the requests if they take more than one second?

[roblourens]

We do have a timeout of 5 seconds, but @alexandrudima bypassed it because it's implemented by XHR. So I think that isn't a good test.

[roblourens]

But I'll look at @sandy081's change

[roblourens]

I see that the earlier progress bar change caused the local search to wait on the remote search, and the new change decouples them, which is correct.

I debugged some and realized that I'm doing something slightly wrong, in that the remote search is debounced, but each new search waits on the old one to complete. It should actually fire immediately and cancel the previous search if it has not completed yet. I didn't realize that the ThrottledDelayer is queuing the promises, makes sense though.

I have a change to make the ThrottledDelayer simply not wait on the search to complete. But, I don't think I want to check it in now because the impact isn't that bad, with the remote search timeout. And it isn't noticeable under normal network conditions. The change is here: 0dbb7a0

But @sandy081 I've tried a lot and I can't repro what you show where the results show up after the query has been cleared. That shouldn't happen, due to the search being canceled when the query is cleared.

[sandy081]

@roblourens Good.

Opened a separate issue to improve this throttled behaviour - #42814

Closing this one as decoupling local and remote searches fixes this issue.

[alexdima]

Thank you!