Cancelling opening a folder from a multi-root unsaved workspace corrupts the current worksapce

[jtanx]

• VSCode Version: 1.19.3
• OS Version: Windows 10 10.0.16299.125

Steps to Reproduce:

1. Have an unsaved multi-root workspace (e.g. add two folders to the same workspace)
2. Have an integrated terminal open
3. Attempt to open a folder (CTRL + K O)
4. At the confirmation box, click cancel:
   
5. Terminal is now broken:
   
6. Various other things are broken. For example, I can't run extension commands any more.

Does this issue occur when all extensions are disabled?: Yes

[bpasero]

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@Tyriar you might be disposing something on the wrong phase (before shutdown vs on shutdown)?

[jtanx]

I just tried on insiders and it does the same thing.

It's not just limited to the terminal, it's like it reaches a state where things are semi-destructed - including interacting with extensions - try run any extension command and it won't work.

Oh yeah, I've also noticed that the tab bar goes into a weird state as well - it no longer reflects the opened file. But this only happens sometimes; I find it harder to repro:

Click to expand

[bpasero]

I can reproduce. Should probably first ask the main window to veto the unload before even forwarding this to the window.