Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select in the Explorer: Delete deselected folder instead of selected ones #43233

Closed
tsalinger opened this issue Feb 8, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@tsalinger
Copy link
Contributor

Issue Type

Bug

Description

  1. Multi-select several folders in the explorer.
  2. Deselect a single folder (CTRL+Click)
  3. Use the delete key on the keyboard

Expected: It should delete the folders in the multi-selection
Actual: It wants to delete the deselected folder

VSCode:
multiselect_deselectone_delete_vscode

Windows Explorer shows a different behavior:
multiselect_deselectone_delete_windowsexplorer

VS Code Info

VS Code version: Code - Insiders 1.21.0-insider (91120eb, 2018-02-08T05:16:13.920Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz (4 x 2694)
Memory (System) 7.88GB (2.48GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 0%
Extensions (5)
Extension Author (truncated) Version
regex chr 0.1.0
tslint eg2 1.0.24
python ms- 2018.1.0
ayu tea 0.12.0
vscode-todo-highlight way 0.5.11
Reproduces without extensions
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Feb 9, 2018
@isidorn isidorn added this to the February 2018 milestone Feb 9, 2018
@isidorn isidorn closed this as completed in c31b2f2 Feb 9, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 9, 2018

@tsalinger good catch, I have fixed this in the explorer.

@joaomoreno I see the same issue in the list - if an element is being removed from a selection, it should not be focused. I tried fixing this by changing code here however did not want to do it without your approval.

@joaomoreno
Copy link
Member

@isidorn Sure, do what makes sense.

isidorn added a commit that referenced this issue Feb 16, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 16, 2018

@joaomoreno I have pushed 5dc3c59
This changes the following:

  • If a selection change range, focus the element clicked. Previously focus was not changed which I felt was wrong
  • If an element is removed from a selection do not focus it

@bpasero bpasero added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants