Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customization of search match text color #43283

Closed
brunobely opened this issue Feb 9, 2018 · 2 comments
Closed

Allow customization of search match text color #43283

brunobely opened this issue Feb 9, 2018 · 2 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations editor-theming Issues related to the way themes are applied to editors feature-request Request for new features or functionality
Milestone
Backlog

Comments

@brunobely
Copy link

I couldn't find this by searching, but it would be very good for readability if we could add the option to change the foreground color for find matches (editor.findMatchForeground?). Otherwise, we have to pick a background color that won't clash with any possible color in our theme, which is not an easy feat.

Example of how it works now in VS Code:
image

Example of how it works in Sublime:
image
@vscodebot vscodebot bot added the themes Color theme issues label Feb 9, 2018
@octref octref added the editor-find Editor find operations label Feb 12, 2018
@alexdima alexdima added feature-request Request for new features or functionality editor-rendering Editor rendering issues and removed themes Color theme issues labels Mar 1, 2018
@alexdima alexdima added this to the Backlog milestone Mar 1, 2018
@alexdima alexdima removed their assignment Apr 17, 2018
@ccinelli ccinelli mentioned this issue Nov 20, 2018
Closed
@matthias-ccri
Copy link

See #29091

@alexdima alexdima added editor-theming Issues related to the way themes are applied to editors and removed editor-rendering Editor rendering issues labels Oct 23, 2019
@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations editor-theming Issues related to the way themes are applied to editors feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@rebornix @octref @brunobely @alexdima @matthias-ccri and others