[themes] Add editor.findMatchForeground

[ashclarke]

When using Find & Replace, I like to highlight the current search match differently. This is particularly helpful when refactoring and proof-reading, especially if there are many matches.

I can add a colour customisation for editor.findMatchBackground to achieve this. However, as the foreground colour is not editable, I have a contrast issue with the default foreground colour in the theme.

In my case, I'd prefer to set the background colour to something light, like #b2b231 and change the foreground colour of the match to #000000.

Obviously not a pressing issue; a nice to have 👍

[jacobcassidy]

Any progress on this issue? Support for TextMate's "findHighlightForeground" would solve this too. I'm unable to use the "editor.findMatchBackground" as intended because there's currently no way to change the foreground. Which means when the foreground of the text happens to be the same as the background, it disappears into the block.

See screenshots below for clarity....

First is VSC where the element's foreground text happens to be the same color as the "editor.findMatchBackground" color:

Then we have SublimeText using findHighlightForeground to set the foreground for the focused match:

[matthias-ccri]

😭

[lqzhgood]

I think all font state Foreground colors should be supported.
Like wordHighlight selectionHighlight ....

Because color and background are usually paired.

[thisVioletHydra]

pls add Foreground!

[TarasIvaschuk]

pls add!!!

[radek-jurica]

So I guess there is no way how to change the findmatchforeground color right?

[Iron27]

Yes, please add:
editor.findMatchForeground
editor.findMatchHighlightForeground (ideal, but optional as editor.findMatchForeground can likely offer sufficient contrast for both contexts)

Thank you!

[carpii]

is editor.findMatchForeground still unsupported, or or is there some theming stuff I should be using instead?

If not please consider implementing it. It seems like a fairly obvious UI setting, but its now 7 years since it was first suggested

Thanks

[alexr00]

I might be misunderstanding how this is supposed to work, but if editor.findMatchForeground isn't explicitly set by the theme, then I expect the find matches to keep their syntax highlighting colors, like this:

However, instead I see that all find matches have the same foreground, even though it isn't set by my theme or by my settings:

This can look more dramatic with my usual theme:

[SimonSiefke]

@alexr00 That's a bug, thanks for finding! PR #213686 should fix it!