Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'path' of undefined error when TreeItem has empty label #43466

Closed
ansyral opened this issue Feb 12, 2018 · 1 comment
Closed

Cannot read property 'path' of undefined error when TreeItem has empty label #43466

ansyral opened this issue Feb 12, 2018 · 1 comment
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues verified Verification succeeded
Milestone
January 2018 Reco...

Comments

@ansyral
Copy link

ansyral commented Feb 12, 2018

  • VSCode Version: 1.20.0
  • OS Version: Windows10

I have a customized explorer view to show the layout of tree structure. And if TreeItem contains children whose label is empty, when selecting the node to expand its children, vscode pop out error "Cannot read property 'path' of undefined". This used to work before 1.20.0, any idea of the error? Thanks.

The detailed stacktrace is as below:

image
@ansyral ansyral mentioned this issue Feb 12, 2018
Closed
@vscodebot vscodebot bot removed the new release label Feb 12, 2018
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues labels Feb 13, 2018
@sandy081 sandy081 added this to the January 2018 Recovery milestone Feb 13, 2018
sandy081 added a commit that referenced this issue Feb 13, 2018
@sandy081
Fix #43466 in 1.20
8144fc9
@Tyriar
Copy link
Member

Tyriar commented Feb 13, 2018

Verified via code review

@Tyriar Tyriar added the verified Verification succeeded label Feb 13, 2018
@zoehneto zoehneto mentioned this issue Feb 14, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
January 2018 Recovery
Development

No branches or pull requests
3 participants
@ansyral @Tyriar @sandy081