Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeItem with undefined CollapsibleState still shows triangle expander #43608

Closed
ejizba opened this issue Feb 13, 2018 · 1 comment
Closed

TreeItem with undefined CollapsibleState still shows triangle expander #43608

ejizba opened this issue Feb 13, 2018 · 1 comment
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone
February 2018

Comments

@ejizba
Copy link
Member

ejizba commented Feb 13, 2018

We started noticing this bug on insiders a few days ago. We haven't changed our TreeDataProvider, but now even leaf nodes have the triangle expander thing.

Before:
screen shot 2018-02-13 at 10 49 35 am

Now:
screen shot 2018-02-13 at 10 50 23 am

@sandy081 I'm guessing it might have to do with the change to hasChildren in this commit: 125ac04#diff-094f2529578f3d0493f637a194e2687bR339

VS Code version: Code - Insiders 1.21.0-insider (00f2d8e, 2018-02-13T06:08:48.197Z)
OS version: Darwin x64 17.4.0
@ejizba ejizba mentioned this issue Feb 13, 2018
Closed
@sandy081
Copy link
Member

Yeah, its broken in insiders as I was falsly assuming that the tree item has always collapsible state.

Default is always none.

Fixed it.

Thanks @EricJizbaMSFT for reporting.

@sandy081 sandy081 self-assigned this Feb 14, 2018
@sandy081 sandy081 added this to the February 2018 milestone Feb 14, 2018
@sandy081 sandy081 added extension-host Extension host issues bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues and removed extension-host Extension host issues labels Feb 14, 2018
sandy081 added a commit that referenced this issue Feb 14, 2018
@sandy081
##43608 Fix tests
dfda71a
@octref octref added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@octref @sandy081 @ejizba