Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IExtensionService up to /workbench/ #44281

Closed
alexdima opened this issue Feb 23, 2018 · 0 comments
Closed

Move IExtensionService up to /workbench/ #44281

alexdima opened this issue Feb 23, 2018 · 0 comments
Assignees
@alexdima
Labels
debt Code quality issues
Milestone
February 2018

Comments

@alexdima
Copy link
Member

alexdima commented Feb 23, 2018 •
edited

The standalone editor should not end up depending on vscode extensions, so it is best if we move this service up to /workbench/
@alexdima alexdima added the debt Code quality issues label Feb 23, 2018
@alexdima alexdima self-assigned this Feb 23, 2018
@alexdima alexdima added this to the February 2018 milestone Feb 23, 2018
alexdima added a commit that referenced this issue Feb 23, 2018
@alexdima
Move CommandService implementation up to /workbench/ (#44281)
66a1df3
alexdima added a commit that referenced this issue Feb 23, 2018
@alexdima
Move MenuService implementation up to /workbench/ (#44281)
11df1b5
alexdima added a commit that referenced this issue Feb 23, 2018
@alexdima
Move extension points up to /workbench/ (#44281)
07b2c80
alexdima added a commit that referenced this issue Feb 23, 2018
@alexdima
Move IExtensionService up to /workbench/ (fixes #44281)
8bfa7ff
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
1 participant
@alexdima