Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening launch configs in user or workspace settings should reveal the "launch" section #44542

Closed
weinand opened this issue Feb 27, 2018 · 11 comments
Assignees
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Feb 27, 2018

Testing #44449:

If you have a default launch config in user or workspace settings and you press the gear icon in the debug viewlet, it opens the correct settings file but it does not reveal or highlight the "launch" section.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Feb 27, 2018
@isidorn isidorn added config VS Code configuration, set up issues and removed debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 27, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

This is a great idea, for that the OpenGlobalSettings would need to take an additional option of being passed a setting name.
Assigning also to @sandy081 since he would need to provide that api or to give me some code pointers for that to happen or if our proposal make sense at all.

@isidorn isidorn added this to the On Deck milestone Feb 27, 2018
@isidorn isidorn removed their assignment Jun 8, 2018
@sandy081 sandy081 removed config VS Code configuration, set up issues feature-request Request for new features or functionality labels Nov 16, 2020
@sandy081 sandy081 removed their assignment Nov 16, 2020
@sandy081 sandy081 removed this from the On Deck milestone Nov 16, 2020
@sandy081
Copy link
Member

You can provide the setting to edit using editSetting option.

Eg: this.preferencesService.openGlobalSettings(true, { editSetting: <id> });

@isidorn
Copy link
Contributor

isidorn commented Nov 17, 2020

@sandy081 thanks, I just tried it. Even though this nicely opens the User setting on the correct location it also adds a new line and triggers the suggest widget. Which seems to be expected for the editSetting behavior. Here I do not really want to edit - I simply want that part revealed. Is there some api for that?

@sandy081
Copy link
Member

Ah ok, I can add reveal setting option for your use case.

@sandy081 sandy081 self-assigned this Nov 17, 2020
@sandy081 sandy081 added config VS Code configuration, set up issues feature-request Request for new features or functionality labels Nov 17, 2020
@sandy081 sandy081 added this to the November 2020 milestone Nov 17, 2020
@isidorn
Copy link
Contributor

isidorn commented Nov 17, 2020

Yeah, that would be great, thanks!

@isidorn
Copy link
Contributor

isidorn commented Nov 27, 2020

@sandy081 friendly ping for this. Should we push it out to next milestone? Anything works for me.

@sandy081
Copy link
Member

Will see if I can squeeze it in today, otherwise will move this on Monday. Hope that works.

@isidorn
Copy link
Contributor

isidorn commented Nov 27, 2020

Anything works. Thanks!

sandy081 added a commit that referenced this issue Nov 27, 2020
@sandy081
Copy link
Member

Added support for revealing the setting. Eg:

this.preferencesService.openGlobalSettings(true, { revealSetting: {key: '<id>'} });

@isidorn
Copy link
Contributor

isidorn commented Nov 27, 2020

@sandy081 works lovely, thanks!

@isidorn isidorn added the verification-needed Verification of issue is requested label Nov 27, 2020
@bpasero bpasero added the verified Verification succeeded label Dec 2, 2020
@bpasero
Copy link
Member

bpasero commented Dec 2, 2020

👏

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@bpasero @weinand @isidorn @sandy081 and others