You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
see how the second argument is typed as a URI but actually is not
@isidorn I suggest you make a pass over the file commands, there are probably more cases. I only noticed this issue because I wanted to revert a file and that failed and the error message was not bubbling up because the error message assumes the second argument is a URI.
I guess this would also happen if running a command via command palette.
The text was updated successfully, but these errors were encountered:
bpasero
added
the
bug
Issue identified by VS Code Team member as probable bug
label
Mar 2, 2018
@isidorn actually it looks like you already fixed this issue sort of, I can no longer reproduce the error case. However, the command is still typed such as the second argument would be a URI which is dangerous because in this case where I run it from the menu the second argument is something else:
I think the commands need a URI.isURI check to make sure the argument is what was expected.
Steps to Reproduce:
URI
but actually is not@isidorn I suggest you make a pass over the file commands, there are probably more cases. I only noticed this issue because I wanted to revert a file and that failed and the error message was not bubbling up because the error message assumes the second argument is a URI.
I guess this would also happen if running a command via command palette.
The text was updated successfully, but these errors were encountered: