Viewlet: header gets updated for each view within

[bpasero]

Steps to Reproduce:

1. add a breakpoint here
2. open the debug view

=> the selectbox is created 4 times for each view within

I find that weird, I would only expect the header of a viewlet to change when there is a transition from 1 view to many views or vice versa. And I would possibly not expect this on first creation time of the view where its already known how many views are being added.

[isidorn]

The issue here is panelViewet updates the title area whenever a split view is added.
However this is only needed for the explorer (as some actions can move to the title area).
So I have pushed a fix for this to be only done for the explorer viewlet
@sandy081 please reveiw

[sandy081]

@isidorn View headers and title area are updated depending on the number of views. They are a pair and to be invoked together. I think moving updateTitleArea away from it makes it disconnected and broken.

updateHeaders does it smarty by checking if there is a single view or not. updateTitleArea should also do the same.

I would suggest to combine them into single method and do the updates?

[isidorn]

@sandy081 thanks for feedback.
I think updateHeaders and updateTitleArea can not be moved to a single method since updateTitleArea needs to be called when transitioning in and out of single view mode and that is not the case with updateHeaders. Still I think I covered some of your concerns with the attached commit.

Feel free to change it if you do not like my approach.

[sandy081]

@isidorn your argument makes sense. New change looks good to me.

[bpasero]

@isidorn the SelectBox is created each time I open the debug view but never disposed it seems. There maybe more things leaking when switching views in the title area, I have not checked.

[isidorn]

@bpasero yes that is because I am not caching my debug actions which I plan to tackle as part of this debt item #46867. However this is not related to the main issue thus closing this one