Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirtyDiffModel leaks #45112

Closed
bpasero opened this issue Mar 6, 2018 · 1 comment
Closed

DirtyDiffModel leaks #45112

bpasero opened this issue Mar 6, 2018 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone
March 2018

Comments

@bpasero
Copy link
Member

bpasero commented Mar 6, 2018 •
edited

Steps to Reproduce:

  1. open 2 editors under git and make a heap snapshot
  2. jump between editor 1 and 2 10 times

=> note 10 DirtyDiffModels added

It looks like the dispose method of this model is never called.
@bpasero
Copy link
Member Author

bpasero commented Mar 6, 2018

Hm I think the dispose method is actually called, but the snapshot tool is still showing 10 models hanging around:

image

Maybe some listener is not disposed or the model is being hold on to somewhere else?

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Mar 6, 2018
@joaomoreno joaomoreno added this to the March 2018 milestone Mar 6, 2018
@joaomoreno joaomoreno added the scm General SCM compound issues label Mar 6, 2018
joaomoreno added a commit that referenced this issue Mar 6, 2018
@joaomoreno
dispose dirty diff controller disposables
a255de3 
related to #45112
@bpasero bpasero added the verified Verification succeeded label Mar 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
2 participants
@joaomoreno @bpasero