Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep scroll position stable when closing a tab in the tab well #45527

Closed
LAITONEN opened this issue Mar 11, 2018 · 9 comments
Closed

Keep scroll position stable when closing a tab in the tab well #45527

LAITONEN opened this issue Mar 11, 2018 · 9 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone
March 2018

Comments

@LAITONEN
Copy link

LAITONEN commented Mar 11, 2018 •
edited

  • VSCode Version: 1.21.0
  • OS Version: Sierra 10.12.6

Steps to Reproduce:
Basically, this "bug" is still a thing. Can't comment there, thus creating a new issue.
@bpasero
Copy link
Member

bpasero commented Mar 12, 2018

"explorer.autoReveal": false

@bpasero bpasero closed this as completed Mar 12, 2018
@LAITONEN
Copy link
Author

LAITONEN commented Mar 12, 2018 •
edited

@bpasero No, this does not help.

@bpasero
Copy link
Member

bpasero commented Mar 12, 2018

@LAITONEN what do you see?

@LAITONEN
Copy link
Author

@bpasero This when I have the leftmost tab open, scroll to the right and close rightmost tab.

@bpasero
Copy link
Member

bpasero commented Mar 12, 2018

@LAITONEN when you say "Explorer" I assumed you mean the file explorer to the left. So you say when you close a tab, the tab-well scrolls? How do you close a tab?

@bpasero bpasero reopened this Mar 12, 2018
@bpasero bpasero added the info-needed Issue requires more information from poster label Mar 12, 2018
@LAITONEN LAITONEN changed the title Explorer scrolls on file close Tab bar scrolls on file close Mar 12, 2018
@LAITONEN LAITONEN changed the title Tab bar scrolls on file close Tab bar / tab-well scrolls on file close Mar 12, 2018
@LAITONEN
Copy link
Author

@bpasero My apologies, this was a silly mistake, rectified by now.
I close it by clicking the cross icon.

@bpasero
Copy link
Member

bpasero commented Mar 13, 2018

@LAITONEN yes I see it, looks like a regression.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 13, 2018
@bpasero bpasero added this to the March 2018 milestone Mar 13, 2018
@bpasero bpasero changed the title Tab bar / tab-well scrolls on file close Keep scroll position stable when closing a tab in the tab well Mar 13, 2018
@bpasero bpasero added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues and removed bug Issue identified by VS Code Team member as probable bug labels Mar 13, 2018
@bpasero bpasero removed their assignment Mar 13, 2018
@bpasero bpasero removed this from the March 2018 milestone Mar 13, 2018
@bpasero
Copy link
Member

bpasero commented Mar 13, 2018 •
edited

Unfortunately our refactorings and repeated layout calls make this not as straight forward as I had hoped. I will have to leave this open until I found a better solution...

A small workaround to prevent the tabs from scrolling is to configure "workbench.editor.tabSizing": "shrink"

bpasero added a commit that referenced this issue Mar 13, 2018
@bpasero
revert some things for #45527 that do not work anymore
62cfab5
@vscodebot vscodebot bot removed the new release label Mar 13, 2018
@LAITONEN
Copy link
Author

@bpasero Thank you! That will work temporally.

@bpasero bpasero self-assigned this Mar 13, 2018
@bpasero bpasero added this to the March 2018 milestone Mar 13, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Mar 13, 2018
@bpasero bpasero closed this as completed Mar 13, 2018
bpasero added a commit that referenced this issue Mar 13, 2018
@bpasero
Keep scroll position stable when closing a tab in the tab well (fixes #…
b6c47c2 
…45527)
@bpasero bpasero mentioned this issue Mar 17, 2018
Closed
@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
3 participants
@bpasero @RMacfarlane @LAITONEN