Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackupMainService failing tests #45745

Closed
joaomoreno opened this issue Mar 14, 2018 · 1 comment
Closed

BackupMainService failing tests #45745

joaomoreno opened this issue Mar 14, 2018 · 1 comment
Assignees
Labels
debt Code quality issues workbench-hot-exit Preservation of unsaved changes across restarts

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 14, 2018

These tests often fail with timeouts. Not sure whether IO is really slow, or if there's really something wrong with the test never completing.

From https://monacotools.visualstudio.com/Monaco/Monaco%20Team/_build/index?buildId=36877&_a=summary

2018-03-14T09:51:21.6073241Z FAIL BackupMainService service validates backup workspaces on startup and cleans up (folder workspaces) (5500ms)
2018-03-14T09:51:21.7448159Z OK   BackupMainService service validates backup workspaces on startup and cleans up (root workspaces) (129ms)
2018-03-14T09:51:21.7862436Z OK   BackupMainService service supports to migrate backup data from another location (22ms)
2018-03-14T09:51:21.8353557Z OK   BackupMainService service backup migration makes sure to preserve existing backups (41ms)
2018-03-14T09:51:21.8430528Z OK   BackupMainService loadSync getFolderBackupPaths() should return [] when workspaces.json doesn't exist (0ms)
2018-03-14T09:51:21.8533334Z OK   BackupMainService loadSync getFolderBackupPaths() should return [] when workspaces.json is not properly formed JSON (1ms)
2018-03-14T09:51:21.8611434Z OK   BackupMainService loadSync getFolderBackupPaths() should return [] when folderWorkspaces in workspaces.json is absent (1ms)
2018-03-14T09:51:21.8681423Z OK   BackupMainService loadSync getFolderBackupPaths() should return [] when folderWorkspaces in workspaces.json is not a string array (2ms)
2018-03-14T09:51:21.9004328Z OK   BackupMainService loadSync getFolderBackupPaths() should return [] when files.hotExit = "onExitAndWindowClose" (27ms)
2018-03-14T09:51:21.9079491Z OK   BackupMainService loadSync getWorkspaceBackups() should return [] when workspaces.json doesn't exist (0ms)
2018-03-14T09:51:21.9149744Z OK   BackupMainService loadSync getWorkspaceBackups() should return [] when workspaces.json is not properly formed JSON (1ms)
2018-03-14T09:51:21.9245066Z OK   BackupMainService loadSync getWorkspaceBackups() should return [] when folderWorkspaces in workspaces.json is absent (1ms)
2018-03-14T09:51:21.9365018Z OK   BackupMainService loadSync getWorkspaceBackups() should return [] when rootWorkspaces in workspaces.json is not a object array (1ms)
2018-03-14T09:51:21.9700255Z OK   BackupMainService loadSync getWorkspaceBackups() should return [] when files.hotExit = "onExitAndWindowClose" (24ms)
2018-03-14T09:51:21.9773828Z OK   BackupMainService loadSync getEmptyWorkspaceBackupPaths() should return [] when workspaces.json doesn't exist (0ms)
2018-03-14T09:51:21.9834768Z OK   BackupMainService loadSync getEmptyWorkspaceBackupPaths() should return [] when workspaces.json is not properly formed JSON (1ms)
2018-03-14T09:51:21.9919046Z OK   BackupMainService loadSync getEmptyWorkspaceBackupPaths() should return [] when folderWorkspaces in workspaces.json is absent (0ms)
2018-03-14T09:51:22.0000606Z OK   BackupMainService loadSync getEmptyWorkspaceBackupPaths() should return [] when folderWorkspaces in workspaces.json is not a string array (2ms)
2018-03-14T09:51:22.0102679Z OK   BackupMainService dedupeFolderWorkspaces should ignore duplicates on Windows and Mac (folder workspace) (0ms)
2018-03-14T09:51:22.0172641Z OK   BackupMainService dedupeFolderWorkspaces should ignore duplicates on Windows and Mac (root workspace) (0ms)
2018-03-14T09:51:22.0543102Z OK   BackupMainService registerWindowForBackups should persist paths to workspaces.json (folder workspace) (29ms)
2018-03-14T09:51:22.0828290Z OK   BackupMainService registerWindowForBackups should persist paths to workspaces.json (root workspace) (18ms)
2018-03-14T09:51:22.1076664Z OK   BackupMainService registerWindowForBackups should always store the workspace path in workspaces.json using the case given, regardless of whether the file system is case-sensitive (folder workspace) (13ms)
2018-03-14T09:51:22.1287854Z OK   BackupMainService registerWindowForBackups should always store the workspace path in workspaces.json using the case given, regardless of whether the file system is case-sensitive (root workspace) (11ms)
2018-03-14T09:51:22.1746104Z OK   BackupMainService removeBackupPathSync should remove folder workspaces from workspaces.json (folder workspace) (32ms)
2018-03-14T09:51:22.2226206Z OK   BackupMainService removeBackupPathSync should remove folder workspaces from workspaces.json (root workspace) (36ms)
2018-03-14T09:51:22.2708333Z OK   BackupMainService removeBackupPathSync should remove empty workspaces from workspaces.json (34ms)
2018-03-14T09:51:22.2958446Z OK   BackupMainService removeBackupPathSync should fail gracefully when removing a path that doesn't exist (14ms)
2018-03-14T09:51:22.3074516Z OK   BackupMainService getWorkspaceHash should perform an md5 hash on the path (0ms)
2018-03-14T09:51:22.3165038Z OK   BackupMainService getWorkspaceHash should ignore case on Windows and Mac (0ms)
2018-03-14T09:51:22.3483023Z OK   BackupMainService mixed path casing should handle case insensitive paths properly (registerWindowForBackupsSync) (folder workspace) (22ms)
2018-03-14T09:51:22.3719432Z OK   BackupMainService mixed path casing should handle case insensitive paths properly (registerWindowForBackupsSync) (root workspace) (18ms)
2018-03-14T09:51:22.4042029Z OK   BackupMainService mixed path casing should handle case insensitive paths properly (removeBackupPathSync) (folder workspace) (26ms)
2018-03-14T09:51:33.7830330Z   1) BackupMainService service validates backup workspaces on startup and cleans up (folder workspaces):
2018-03-14T09:51:33.7863745Z      Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.
bpasero added a commit that referenced this issue Mar 14, 2018
@bpasero
Copy link
Member

bpasero commented Mar 14, 2018

Lets first increase the timeout and monitor the test further. I see only sync execution in that test so I would expect any error to bubble up properly to the console.

@bpasero bpasero added debt Code quality issues workbench-hot-exit Preservation of unsaved changes across restarts labels Mar 14, 2018
@bpasero bpasero closed this as completed Apr 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues workbench-hot-exit Preservation of unsaved changes across restarts
Projects
None yet
Development

No branches or pull requests

3 participants