Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files.trimFinalNewlines unnecessarily adds extra event to undo history #46075

Closed
garyking opened this issue Mar 19, 2018 · 0 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@garyking
Copy link

garyking commented Mar 19, 2018

This was also discussed in #39750 and apparently fixed in #39845, but I'm still experiencing this.

Steps to reproduce:

  1. Set files.trimFinalNewlines to true in settings.
  2. Create a file, and add the following contents:
Test

Ensure that there's an empty newline at the end. Save it. Then hit Undo. Nothing will happen. Hit Undo again, then it will work as expected.

You can even hit Save multiple times, and each time will add one extra step to the Undo list. So hit Save 10 times, then you can hit Undo 10 times and nothing will happen.

@AiryShift Could you take a look at this if possible?

@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Mar 19, 2018
AiryShift added a commit to AiryShift/vscode that referenced this issue Mar 21, 2018
This should reproduce the bug as described in microsoft#46075 but doesn't
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug and removed editor editor-core Editor basic functionality labels Mar 28, 2018
@alexdima alexdima added this to the March 2018 milestone Mar 28, 2018
alexdima added a commit that referenced this issue Mar 28, 2018
@rebornix rebornix added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants