Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet snippet "iframe" is higher than "if" #46305

Closed
user3323 opened this issue Mar 22, 2018 · 3 comments
Closed

Emmet snippet "iframe" is higher than "if" #46305

user3323 opened this issue Mar 22, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@user3323
Copy link

  • VSCode Version: 1.22.0-ins
  • OS Version: win7x64

image

@vscodebot vscodebot bot added the emmet Emmet related issues label Mar 22, 2018
@ramya-rao-a
Copy link
Contributor

Is the if here a js/ts snippet here?

@user3323
Copy link
Author

@ramya-rao-a

happens in .ts

snippet if is from - TypeScript Language Basics

iframe if

so, it happens because of "including rule" in the settings:

"emmet.includeLanguages": {
    "typescript": "html"
  }

it's good that we can have Emmet snippets in the .ts files, but not good that Emmet push all it's snippets to the top, regardless of basic alphabetic order.

@ramya-rao-a ramya-rao-a added this to the March 2018 milestone Mar 26, 2018
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Mar 26, 2018
ramya-rao-a added a commit to microsoft/vscode-emmet-helper that referenced this issue Mar 26, 2018
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @user3323!
The fix will be available in tomorrow's Insiders build.

Note to verifier:
Add the below settings to repro the issue in 1.21 stable

"emmet.includeLanguages": {
    "typescript": "html"
  }
 "emmet.showSuggestionsAsSnippets": true,
    "editor.snippetSuggestions": "top"

@tsalinger tsalinger added the verified Verification succeeded label Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants