Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet bem filter problem when child uses multiple classes #46511

Closed
roamn opened this issue Mar 25, 2018 · 6 comments
Closed

Emmet bem filter problem when child uses multiple classes #46511

roamn opened this issue Mar 25, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@roamn
Copy link

roamn commented Mar 25, 2018

  • VSCode Version: 1.21.1
  • OS Version: Windows 10/64

Steps to Reproduce:

Abbreviation to expand included modificator name
.l-layout>.-container.container>.-row.row>.-col_some_modif_name.col-xs-12

Result in VSC

2018-03-26_01-49-43

Expected result

Result in Sublime Text

2018-03-26_01-50-42

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the emmet Emmet related issues label Mar 25, 2018
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @roamn
I have logged an upstream issue for the same. emmetio/html-transform#12

@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Mar 26, 2018
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, March 2018 Mar 26, 2018
@ramya-rao-a ramya-rao-a changed the title Emmet bem filter problem Emmet bem filter problem when child uses multiple classes Mar 26, 2018
@ramya-rao-a ramya-rao-a modified the milestones: March 2018, April 2018 Mar 28, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 28, 2018

There are 2 issues here.

I have submitted PRs upstream to fix both these issues, but it is unlikely that they will make it in time for the March release though. Pushing this bug to the next milestone

@roamn
Copy link
Author

roamn commented Mar 28, 2018

Thanks.

ramya-rao-a added a commit that referenced this issue Apr 12, 2018
@ramya-rao-a
Copy link
Contributor

The fix for this will be available in tomorrow's Insiders

@mjbvz mjbvz added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Apr 26, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Apr 26, 2018

@ramya-rao-a Here's the result I see in the current insiders:

     <div class="l-layout">
         <div class="-container container">
             <div class="-row row">
                 <div class="-col_some_modif_name col-xs-12"></div>
             </div>
         </div>
     </div>

Which doesn't match the sublime example

@mjbvz mjbvz reopened this Apr 26, 2018
@ramya-rao-a
Copy link
Contributor

@mjbvz You need to either add |bem in the end or add the below setting

"emmet.syntaxProfiles": {
        "html": {
            "filters": "bem"
        }
    }

@ramya-rao-a ramya-rao-a removed the verification-found Issue verification failed label Apr 26, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants