Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command tracking should show glyphs next to rows and flash lines when navigating #46561

Closed
Tyriar opened this issue Mar 26, 2018 · 6 comments · Fixed by #145245
Closed

Command tracking should show glyphs next to rows and flash lines when navigating #46561

Tyriar opened this issue Mar 26, 2018 · 6 comments · Fixed by #145245
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 26, 2018

Follow up for #45435

cmd+up/down on macOS should show some indication of the line that was scrolled to.

This will need some upstream changes.

@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal Integrated terminal issues labels Mar 26, 2018
@Tyriar Tyriar added this to the Backlog milestone Mar 26, 2018
@Tyriar Tyriar self-assigned this Mar 26, 2018
@chrisdias
Copy link
Member

chrisdias commented Mar 27, 2018

testing #46594

if i have a few empty lines such as this:

image

pressing cmd+up appears to do nothing, so having some indication of where I am would be great.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 27, 2018

@chrisdias yeah I would have liked to get this in but was a bit randomized this iteration.

@Tyriar
Copy link
Member Author

Tyriar commented Oct 8, 2019

Blocked on xtermjs/xterm.js#1852

@Tyriar
Copy link
Member Author

Tyriar commented Mar 16, 2022

Brought this to UX sync with a focus border outline that fades to 0 opacity over 2 seconds. But after it occurred to me that navigating the a symbol in the editor is the exact idea we're trying to get across which flashes a focus border briefly without animating. So going with that to align, we can change both if we want to tweak it:
Recording 2022-03-16 at 10 31 04

@Tyriar
Copy link
Member Author

Tyriar commented Mar 16, 2022

Using 350ms:

if (highlight) {
const modelNow = targetEditor.getModel();
const ids = targetEditor.deltaDecorations([], [{ range, options: { description: 'symbol-navigate-action-highlight', className: 'symbolHighlight' } }]);
setTimeout(() => {
if (targetEditor.getModel() === modelNow) {
targetEditor.deltaDecorations(ids, []);
}
}, 350);
}

@Tyriar
Copy link
Member Author

Tyriar commented Mar 16, 2022

Recording 2022-03-16 at 10 33 52

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@chrisdias @Tyriar @meganrogge and others